main.lua now including Subtletey rogue

Orynge · Post by **Orynge** » 23 Sep 2017, 18:30

Known issues:

1. Switching specs you will have to reload only to fix the MaxDps.Description setting. This setting seems to be
retained from prior spec load.

2. Not sure my use of MaxDps:TargetsInRange(_ShurikenStorm) is correct, since target value not getting set, or from
what I can tell my spell ShurikenStorm is never getting called out(highlighted)

3. Multiple abilities are highlighted from the start; it us up to user to figure out their ideal Subtlety rotation from the
start.

Below is my first workable version of my new main.lua file that now includes the rogue Subtlety spec rotation.
-----------------------------------------------------------------------------------------------------------------

Code: [Select all] [Expand/Collapse]

-- Outlaw
local _BladeFlurry = 13877;
local _RolltheBones = 193316;
local _TrueBearing = 193359;
local _SharkInfestedWaters = 193357;
local _GhostlyStrike = 196937;
local _CurseoftheDreadblades = 202665;
local _AdrenalineRush = 13750;
local _MarkedforDeath = 137619;
local _RunThrough = 2098;
local _Broadsides = 193356;
local _PistolShot = 185763;
local _Opportunity = 195627;
local _SaberSlash = 193315;
local _Ambush = 8676;
local _CheapShot = 1833;
local _PreyontheWeak = 131511;
local _DeeperStratagem = 193531;
local _JollyRoger = 199603;
local _GrandMelee = 193358;
local _BuriedTreasure = 199600;
local _SliceandDice = 5171;
local _DeathfromAbove = 152150;
local _Vigor = 14983;
local _CombatPotency = 35551;
local _Bloodlust = 2825;
local _Heroism = 32182;
local _TimeWarp = 80353;
local _Ruthlessness = 14161;
local _Sprint = 2983;
local _BetweentheEyes = 199804;
local _Blind = 2094;
local _CloakofShadows = 31224;
local _Riposte = 199754;
local _GrapplingHook = 195457;
local _CannonballBarrage = 185767;
local _KillingSpree = 51690;
local _Feint = 1966;
local _Elusiveness = 79008;
local _CheatDeath = 31230;
local _CrimsonVial = 185311;
local _HiddenBlade = 202753;
 
-- Auras
local _Stealth = 1784;
local _Vanish = 1856;
 
-- Subtlety
local _ShadowBlades = 121471;
local _ShadowDance = 185313;
local _ShadowStrike = 185438;
local _GoremawsBite = 209782;
local _NightBlade = 195452;
local _SymbolsofDeath = 212283;
local _Eviscerate = 196819;
local _BackStab = 53;
local _DeathfromAbove = 152150;
local _ShurikenStorm = 197835;
local _Shadowstep = 36554;
local _Feint = 1966;
local _ShurikenToss = 114014;
local _KidneyShot = 408;
local _CheapShot = 1833;
 
 
-- Talents
local _isGhostlyStrike = false;
local _isMarkedforDeath = false;
local _isDeathfromAbove = false;
 
MaxDps.Rogue = {};
 
function MaxDps.Rogue.CheckTalents()
    MaxDps:CheckTalents();
    _isGhostlyStrike = MaxDps:HasTalent(_GhostlyStrike);
    _isMarkedforDeath = MaxDps:HasTalent(_MarkedforDeath);
    _isDeathfromAbove = MaxDps:HasTalent(_DeathfromAbove);
end
 
function MaxDps:EnableRotationModule(mode)
    mode = mode or 1;
    -- MaxDps.Description = 'Rogue [Outlaw]';
    MaxDps.ModuleOnEnable = MaxDps.Rogue.CheckTalents;
    if mode == 1 then
        MaxDps.NextSpell = MaxDps.Rogue.Assassination;
    end;
    if mode == 2 then
        MaxDps.Description = 'Rogue [Outlaw]';
        MaxDps.NextSpell = MaxDps.Rogue.Outlaw;
    end;
    if mode == 3 then
         MaxDps.Description = 'Rogue [Subtlety]';
         MaxDps.NextSpell = MaxDps.Rogue.Subtlety;
    end;
end
 
function MaxDps.Rogue.Assassination()
    local timeShift, currentSpell, gcd = MaxDps:EndCast();
 
    return nil;
end
 
function MaxDps.Rogue.Outlaw()
    local timeShift, currentSpell, gcd = MaxDps:EndCast();
 
    local energy = UnitPower('player', SPELL_POWER_ENERGY);
    local combo = GetComboPoints('player', 'target');
 
    MaxDps:GlowCooldown(_AdrenalineRush, MaxDps:SpellAvailable(_AdrenalineRush, timeShift));
    MaxDps:GlowCooldown(_CurseoftheDreadblades, MaxDps:SpellAvailable(_CurseoftheDreadblades, timeShift));
    MaxDps:GlowCooldown(_KillingSpree, MaxDps:SpellAvailable(_KillingSpree, timeShift));
 
    if MaxDps:PersistentAura(_Stealth, timeShift) then
        return _Ambush;
    end
 
    local curse = MaxDps:Aura(_CurseoftheDreadblades, timeShift, 'HARMFUL');
 
    -- roll the bones auras
    local rb = {
        TB = MaxDps:Aura(_TrueBearing, timeShift + 3),
        SIW = MaxDps:Aura(_SharkInfestedWaters, timeShift + 3),
        JR = MaxDps:Aura(_JollyRoger, timeShift + 3),
        GM = MaxDps:Aura(_GrandMelee, timeShift + 3),
        BS = MaxDps:Aura(_Broadsides, timeShift + 3),
        BT = MaxDps:Aura(_BuriedTreasure, timeShift + 3),
    }
    -- buty, sprint co CD
    local rbCount = 0;
    for k, v in pairs(rb) do
        if v then
            rbCount = rbCount + 1;
        end
    end
 
    local shouldRoll = not rb.TB and rbCount < 2;
 
    if shouldRoll and combo >=4 and energy >= 20 then
        return _RolltheBones;
    end
 
    if _isGhostlyStrike and not MaxDps:TargetAura(_GhostlyStrike, timeShift + 3) and energy > 30 then
        return _GhostlyStrike;
    end
 
    if _isMarkedforDeath and combo < 2 and MaxDps:SpellAvailable(_MarkedforDeath, timeShift) then
        return _MarkedforDeath;
    end
 
    if (combo >= 6 or (combo >= 5 and rb.BS)) then
        return _RunThrough;
    end
 
    if MaxDps:Aura(_Opportunity, timeShift) and combo <= 4 then
        return _PistolShot;
    end
 
    return _SaberSlash;
end
 
 
function MaxDps.Rogue.Subtlety()
    local timeShift, currentSpell, gcd = MaxDps:EndCast();
 
    local energy = UnitPower('player', SPELL_POWER_ENERGY);
    local combo = GetComboPoints('player', 'target');
    local targets = MaxDps:TargetsInRange(_ShurikenStorm);
 
    MaxDps:GlowCooldown(_GoremawsBite, MaxDps:SpellAvailable(_GoremawsBite, timeShift));
    MaxDps:GlowCooldown(_ShadowBlades, MaxDps:SpellAvailable(_ShadowBlades, timeShift));
    MaxDps:GlowCooldown(_Vanish, MaxDps:SpellAvailable(_Vanish, timeShift));
 
    if _isDeathfromAbove then
       MaxDps:GlowCooldown(_DeathfromAbove, MaxDps:SpellAvailable(_DeathfromAbove, timeShift));
    end
 
    MaxDps:GlowCooldown(_ShadowDance, MaxDps:SpellAvailable(_ShadowDance, timeShift));
    MaxDps:GlowCooldown(_SymbolsofDeath, MaxDps:SpellAvailable(_SymbolsofDeath, timeShift));
 
-- The Rotation!
 
    if MaxDps:SpellAvailable(_ShadowBlades, timeShift) then
       return _ShadowBlades;
    end
 
    if MaxDps:SpellAvailable(_ShadowDance, timeShift) and (energy > 80) then
        return _ShadowDance;
    end
 
    if  MaxDps:PersistentAura(_Stealth, timeShift) or MaxDps:PersistentAura(_Vanish, timeShift) then
        if MaxDps:SpellAvailable(_ShadowStrike, timeShift) then
            return _ShadowStrike;
        end
    end
 
    if (MaxDps:SpellAvailable(_DeathfromAbove, timeShift) and MaxDps:Aura(_Stealth, timeShift)) then
        return _DeathfromAbove;
    end
 
    if (MaxDps:SpellAvailable(_GoremawsBite, timeShift)) and (combo <= 3 and energy <= 25) then
        return _GoremawsBite;
    end
 
    if MaxDps:SpellAvailable(_NightBlade, timeShiftsss) and (combo >= 4) then
        return _NightBlade;
    end
 
    if MaxDps:SpellAvailable(_SymbolsofDeath, timeShift) then
        return _SymbolsofDeath;
    end
 
    if  MaxDps:SpellAvailable(_Eviscerate, timeShift) and (combo >= 5) then
        return _Eviscerate;
    end
 
    if targets > 2 then
      return _ShurikenStorm;
    end
 
    return _BackStab;
end

GeSHi © Codebox Plus Extension

Orynge · Post by **Orynge** » 23 Sep 2017, 18:34

Another issue:

ShadowStrike is not highlighted as expected soon after calling ShadowDance. Still need to figure that out.

Post by **Kaminaris** » 24 Sep 2017, 00:31

I am not sure if you know, but since quite long time there is an option to write a single rotation without needing to override whole addon module code:

viewtopic.php?f=4&t=4

Orynge · Post by **Orynge** » 24 Sep 2017, 13:33

Thank you. So for the single rotation for subtlety, simply cut and paste within the pre-built function call the following code:

local _ShadowBlades = 121471;
local _ShadowDance = 185313;
local _ShadowStrike = 185438;
local _GoremawsBite = 209782;
local _NightBlade = 195452;
local _SymbolsofDeath = 212283;
local _Eviscerate = 196819;
local _BackStab = 53;
local _DeathfromAbove = 152150;
local _ShurikenStorm = 197835;
local _Shadowstep = 36554;
local _Feint = 1966;
local _ShurikenToss = 114014;
local _KidneyShot = 408;
local _CheapShot = 1833;

-- Auras
local _Stealth = 1784;
local _Vanish = 1856;

-- Talents
local _isDeathfromAbove = false;

MaxDps.Rogue = {};

function MaxDps.Rogue.CheckTalents()
MaxDps:CheckTalents();
_isDeathfromAbove = MaxDps:HasTalent(_DeathfromAbove);
end

local timeShift, currentSpell, gcd = MaxDps:EndCast();

local energy = UnitPower('player', SPELL_POWER_ENERGY);
local combo = GetComboPoints('player', 'target');
local targets = MaxDps:TargetsInRange(_ShurikenStorm);

MaxDps:GlowCooldown(_GoremawsBite, MaxDps:SpellAvailable(_GoremawsBite, timeShift));
MaxDps:GlowCooldown(_ShadowBlades, MaxDps:SpellAvailable(_ShadowBlades, timeShift));
MaxDps:GlowCooldown(_Vanish, MaxDps:SpellAvailable(_Vanish, timeShift));

if _isDeathfromAbove then
MaxDps:GlowCooldown(_DeathfromAbove, MaxDps:SpellAvailable(_DeathfromAbove, timeShift));
end

MaxDps:GlowCooldown(_ShadowDance, MaxDps:SpellAvailable(_ShadowDance, timeShift));
MaxDps:GlowCooldown(_SymbolsofDeath, MaxDps:SpellAvailable(_SymbolsofDeath, timeShift));

-- The Rotation!

if MaxDps:SpellAvailable(_ShadowBlades, timeShift) then
return _ShadowBlades;
end

if MaxDps:SpellAvailable(_ShadowDance, timeShift) and (energy > 80) then
return _ShadowDance;
end

if (MaxDps:PersistentAura(_Stealth, timeShift)) or (MaxDps:PersistentAura(_Vanish, timeShift)) then
if MaxDps:SpellAvailable(_ShadowStrike, timeShift) then
return _ShadowStrike;
end
end

if (MaxDps:SpellAvailable(_DeathfromAbove, timeShift) and MaxDps:Aura(_Stealth, timeShift)) then
return _DeathfromAbove;
end

if (MaxDps:SpellAvailable(_GoremawsBite, timeShift)) and (combo <= 3 and energy <= 25) then
return _GoremawsBite;
end

if MaxDps:SpellAvailable(_NightBlade, timeShiftsss) and (combo >= 4) then
return _NightBlade;
end

if MaxDps:SpellAvailable(_SymbolsofDeath, timeShift) then
return _SymbolsofDeath;
end

if MaxDps:SpellAvailable(_Eviscerate, timeShift) and (combo >= 5) then
return _Eviscerate;
end

if targets > 2 then
return _ShurikenStorm;
end

return _BackStab;

zalid · Post by **zalid** » 30 Nov 2017, 23:40

I've just tried this.
I placed the rotation in the /maxdps system and it keeps saying :
[string "return local_ShadowBlades = 121471;...."]:1:'<eof>' expected near '='
Any ideas why it's not working ?

Post by **Kaminaris** » 05 Dec 2017, 02:47

Look at this topic:
viewtopic.php?f=4&t=4

basically the code above misses function part,
just above:

function(_, timeShift, currentSpell, gcd)

and just below:

end

zalid · Post by **zalid** » 22 Dec 2017, 02:53

Thanks for the reply and fix. Seems to have gotten it to work though all it seems to do is highlight Goremaw's Bite and nothing else. Shame.

Post by **Kaminaris** » 25 Dec 2017, 11:58

I will check it and see if it works. But i see some bugs there.

Emmaleah · Post by **Emmaleah** » 25 Feb 2018, 07:20

It seems to work. The only problem i had with it is it always says It cant find shadow strike on my bars. I have it on the stance bar for when I am stealthed. but not on the other (unstealthed) which seems to work fine for playing, but makes this setup unhappy.

Post by **Kaminaris** » 26 Feb 2018, 04:20

Yeah thats the major problem with rogue, his bars are changing so unless i will be performing fast scans (which are out of question because it will make FPS drop like crazy) it will be calling Spell not found, you may try to change this piece of code:

core.lua of MaxDps CORE addon, not rogue module, line 387

Code: Select all

function MaxDps:ButtonFetch()
	if self.rotationEnabled then
		if self.fetchTimer then
			self:CancelTimer(self.fetchTimer);
		end
		self.fetchTimer = self:ScheduleTimer('Fetch', 0.5);
	end
end

See there is a timer for fetching buttons set to 0.5s, try setting it to 0.2s or even lower and see what happens.

maxdps.net

main.lua now including Subtletey rogue

main.lua now including Subtletey rogue

Re: main.lua now including Subtletey rogue

Re: main.lua now including Subtletey rogue

Re: main.lua now including Subtletey rogue

Re: main.lua now including Subtletey rogue

Re: main.lua now including Subtletey rogue

Re: main.lua now including Subtletey rogue

Re: main.lua now including Subtletey rogue

Re: main.lua now including Subtletey rogue

Re: main.lua now including Subtletey rogue