Add on update for Bfa/pre-patch

Questions about addon itself.
97 posts Page 1 of 10
cpt_bandit
Posts: 2
Joined: 18 Jul 2018, 15:12


I play a marksmen hunter and with the pre patch for bfa im lost on rotation sorta, was wondering if you had planned to update soon or at all? If so can we get a ETA?
rmilyard
Posts: 7
Joined: 16 May 2018, 05:04


I was also wondering if update is planned.
Kaminaris
Site Admin
Posts: 322
Joined: 25 Jun 2017, 03:45


Yes it is, but since nobody gave a fuck, nobody wanted to help despite my posts on this forum, blizzard forum, mmo champion. The only thing that is gonna be updated now is MaxDps + Hunter (MM/BM).

viewtopic.php?f=4&t=229

Rest of specs will need to wait until I have time and i will probably put like 1-2 specs per weekend.
Wulfknightz
Posts: 11
Joined: 18 Jul 2018, 17:49


I do care and would help if I could unfortunately I use this because I have a hard time with rotations especially on all my toons. Wish I could help cause I love the addon was sad to see it didnt have an update for all my toons. Is there not a way to as a starting point do like a cut and paste from somewhere like icy veins as a starter till later optimized? obviously i know more goes to it than a cut and paste but hopefully you know what I mean.
rmilyard
Posts: 7
Joined: 16 May 2018, 05:04


I would also love to help. Right now only have a 110 mage and rogue. I love the addons and would like to keep using for all my toons.
MrZombieCow
Posts: 11
Joined: 18 Jul 2018, 19:13


As long as you could fix the issue where nothing is showing up, I could help out a bit on rotations. I've changed the Feral Druid's rotation a slight bit so you only do Rip when you have 5 combo points.
Code: Select all
function MaxDps.Druid.Feral(_, timeShift, currentSpell, gcd, talents)

	local energy = UnitPower('player', SPELL_POWER_ENERGY);
	local combo = GetComboPoints('player', 'target');

	local clear = MaxDps:Aura(_ClearCasting, timeShift);
	local bt, btCount = MaxDps:Aura(_Bloodtalons, timeShift);
	local berserk = talents[_IncarnationKingoftheJungle] and _IncarnationKingoftheJungle or _Berserk;

	local bers = MaxDps:Aura(berserk, timeShift);

	local rip, ripCd = MaxDps:TargetAura(_Rip, timeShift);

	local ph = MaxDps:TargetPercentHealth();
	local ash, ashCd = MaxDps:SpellAvailable(_AshamanesFrenzy, timeShift);

	MaxDps:GlowCooldown(_AshamanesFrenzy, ash);
	MaxDps:GlowCooldown(berserk, MaxDps:SpellAvailable(berserk, timeShift));

	if MaxDps:SpellAvailable(_TigersFury, timeShift) and (energy < 20 or bers) then
		return _TigersFury;
	end

	-- Keep Rip from falling off during execute range.
	if rip and ripCd < 3 and (talents[_Sabertooth] or ph < 0.25) then
		return _FerociousBite;
	end

	-- Use Healing Touch at 5 Combo Points, if Predatory Swiftness is about to fall off, at 2 Combo Points before
	-- Ashamane's Frenzy, before Elune's Guidance is cast or before the Elune's Guidance buff gives you a 5th Combo
	-- Point.
	local pred, predCd = MaxDps:Aura(_PredatorySwiftness, timeShift);

	if talents[_Bloodtalons] and pred and (
		combo >= 5 or
		predCd < 2 or
		(not bt and combo == 2 and ashCd < gcd)
	) then
		return _Regrowth;
	end

	-- Use Savage Roar if it's expired and you're at 5 combo points or are about to use Brutal Slash
	if talents[_SavageRoar] and not MaxDps:Aura(_SavageRoar, timeShift + 3) and combo >= 5 then
		return _SavageRoar;
	end

	-- AOE
	-- Thrash has higher priority than finishers at 5 targets (NI)
	-- Replace Rip with Swipe at 8 targets

	-- Refresh Rip at 8 seconds or for a stronger Rip
	if
		(not rip and combo >= 5)
		or
		(combo >= 5 and ripCd < 8 and ph > 0.25 and not talents[_Sabertooth])
	then
		return _Rip;
	end

	if rip and ripCd > 5 and combo >= 5 then
		return _FerociousBite;
	end

	if not MaxDps:TargetAura(_Rake, timeShift + 3) then
		return _Rake;
	end

	if talents[_LunarInspiration] and not MaxDps:TargetAura(_Moonfire, timeShift + 4) then
		return _Moonfire;
	end

	return _Shred;
end
I also updated the code for Windwalker Monk, not 100% sure if this works as intended since I can't test it without the addon working
Code: Select all
-- Spells
local _KegSmash = 121253;
local _Jab = 100780;
local _ExpelHarm = 115072;
local _TigerPalm = 100787;
local _ElusiveBrew = 115308;
local _PurifyingBrew = 119582;
local _BlackoutKick = 100784;
local _ChiExplosion = 157676;

-- Auras
local _HeavyStagger = 124273;
local _ModerateStagger = 124274;
local _Shuffle = 115307;
local _ElusiveBrewAura = 128939;
local _TigerPower = 125359;

-- New
local _FistsofFury = 113656;
local _WhirlingDragonPunch = 152175;
local _TigerPalm = 100780;
local _RisingSunKick = 107428;
local _ChiWave = 115098;
local _BlackoutKick = 100784;
local _BlackoutKickAura = 116768;
local _MarkoftheCrane = 228287;
local _SpinningCraneKick = 101546;
local _StormEarthandFire = 137639;
local _Serenity = 152173;
local _RushingJadeWind = 116847;
local _ChiBurst = 123986;
local _TouchofDeath = 115080;
local _Ascension = 115396;
local _MasteryComboStrikes = 115636;
local _Afterlife = 116092;
local _HealingSphere = 125355;
local _TouchofKarma = 122470;
local _EnergizingElixir = 115288;
local _Roll = 109132;
local _Celerity = 115173;
local _HitCombo = 196740;
local _HitComboAura = 196741;
local _Transcendence = 101643;
local _TranscendenceTransfer = 119996;
local _FistOfTheWhiteTiger = 261947;

local _HitComboAbilities = {
	[_BlackoutKick] = 1,
	[_ChiWave] = 1,
	[_FistsofFury] = 1,
	[_RisingSunKick] = 1,
	[_TigerPalm] = 1,
	[_TouchofDeath] = 1,
	[_StrikeoftheWindlord] = 1,
}

MaxDps.Monk = {};

function MaxDps.Monk.CheckTalents()
end

function MaxDps:EnableRotationModule(mode)
	mode = mode or 1;
	self.Description = 'Monk [Windwalker]';
	self.ModuleOnEnable = MaxDps.Monk.CheckTalents;
	if mode == 1 then
		self.NextSpell = MaxDps.Monk.Brewmaster;
	end;
	if mode == 2 then
		self.NextSpell = MaxDps.Monk.Mistweaver;
	end;
	if mode == 3 then
		self.NextSpell = MaxDps.Monk.Windwalker;
	end;
	self:RegisterEvent('UNIT_SPELLCAST_SUCCEEDED');
	self.lastSpellId = 0;
end

function MaxDps:UNIT_SPELLCAST_SUCCEEDED(event, unitID, spell, rank, lineID, spellID)
	if unitID == 'player' and _HitComboAbilities[spellID] == 1 then
		self.lastSpellId = spellID;
	end
end

function MaxDps.Monk.Brewmaster(_, timeShift, currentSpell, gcd, talents)
	return nil;
end

function MaxDps.Monk.Mistweaver(_, timeShift, currentSpell, gcd, talents)
	return nil;
end

function MaxDps.Monk.Windwalker(_, timeShift, currentSpell, gcd, talents)
	local chi = UnitPower('player', SPELL_POWER_CHI);
	local energy = UnitPower('player', SPELL_POWER_ENERGY);
	local energyMax = UnitPowerMax('player', SPELL_POWER_ENERGY);

	local hit, hitCharges = MaxDps:Aura(_HitComboAura, timeShift);

	local rsk = MaxDps:SpellAvailable(_RisingSunKick, timeShift);
	local fotf, fotfCd = MaxDps:SpellAvailable(_FistsofFury, timeShift);

	if talents[_StormEarthandFire] then
		MaxDps:GlowCooldown(_StormEarthandFire, MaxDps:SpellAvailable(_StormEarthandFire, timeShift));
	end

	if talents[_Serenity] then
		MaxDps:GlowCooldown(_Serenity, MaxDps:SpellAvailable(_Serenity, timeShift));
	end

	MaxDps:GlowCooldown(_TouchofDeath, MaxDps:SpellAvailable(_TouchofDeath, timeShift));

	if talents[_WhirlingDragonPunch]
		and not fotf
		and not rsk
		and MaxDps:SpellAvailable(_WhirlingDragonPunch, timeShift)
	then
		return _WhirlingDragonPunch;
	end
	
	if talents[_FistOfTheWhiteTiger]
		and MaxDps:SpellAvailable(_FistOfTheWhiteTiger, timeShift) and (chi < 3 and (energyMax - energy < 40))
			return _FistOfTheWhiteTiger;
	end

	if fotf and chi >= 2 then
		return _FistsofFury;
	end

	if (chi < 4 and (energyMax - energy < 20)) and (not hit or MaxDps.lastSpellId ~= _TigerPalm) then
		return _TigerPalm;
	end

	if (rsk and chi >= 2) and (not hit or MaxDps.lastSpellId ~= _RisingSunKick) then
		return _RisingSunKick;
	end

	if talents[_ChiWave] and MaxDps:SpellAvailable(_ChiWave, timeShift) then
		return _ChiWave;
	end
	
	if telents[_ChiBurst] and MaxDps:SpellAvailable(_ChiBurst, timeShift) then
		return _ChiBurst;
	end

	local canBlackout = MaxDps:Aura(_BlackoutKickAura, timeShift) or
			(MaxDps:SpellAvailable(_BlackoutKick, timeShift) and chi > 0);
	if
		(canBlackout and (chi > 3 or fotfCd > 3))
		and (not hit or MaxDps.lastSpellId ~= _BlackoutKick)
	then
		return _BlackoutKick;
	end

	if hit and MaxDps.lastSpellId == _TigerPalm then
		return nil;
	else
		return _TigerPalm;
	end
end
This two are the classes I play the most and have a good idea how to play.
bobbyg
Posts: 1
Joined: 18 Jul 2018, 19:47


18 Jul 2018, 17:32Kaminaris wrote:
Yes it is, but since nobody gave a fuck, nobody wanted to help despite my posts on this forum, blizzard forum, mmo champion. The only thing that is gonna be updated now is MaxDps + Hunter (MM/BM).

viewtopic.php?f=4&t=229

Rest of specs will need to wait until I have time and i will probably put like 1-2 specs per weekend.
im sorry imjust seeing this, i dont check forums, if there is anything i can do to help.. i dont know how to write codes but im good at copy and pasting.. im sorry no one helped with your request
DunkyB
Posts: 1
Joined: 19 Jul 2018, 16:42


Without a beta key, it's impossible to assist. I would have if I'd had one. MM Hunter here as well. Thanks for everything you've done!
Thermight
Posts: 1
Joined: 19 Jul 2018, 16:48


18 Jul 2018, 17:32Kaminaris wrote:
Yes it is, but since nobody gave a fuck, nobody wanted to help despite my posts on this forum, blizzard forum, mmo champion. The only thing that is gonna be updated now is MaxDps + Hunter (MM/BM).

viewtopic.php?f=4&t=229

Rest of specs will need to wait until I have time and i will probably put like 1-2 specs per weekend.
I am relatively new to this addon but I appreciate how many specs it supports.
I am sorry to hear that your requests for help were not met for pre-BFA patch.

I am eager to test specs (Monk WW and Druid Feral particularly) whenever you get the time for them. I am also curious how this is implemented and how I can help with under the hood feedback on various skill combos as I am a developer myself (but not of wow addons)
cpt_bandit
Posts: 2
Joined: 18 Jul 2018, 15:12


18 Jul 2018, 17:32Kaminaris wrote:
Yes it is, but since nobody gave a fuck, nobody wanted to help despite my posts on this forum, blizzard forum, mmo champion. The only thing that is gonna be updated now is MaxDps + Hunter (MM/BM).

viewtopic.php?f=4&t=229

Rest of specs will need to wait until I have time and i will probably put like 1-2 specs per weekend.
So when will the first update be put out? and sorry to here you had no help for this patch Id help but im a noob... obviously lol
97 posts Page 1 of 10
drogie łóżka stolik kawowy stół dębowy rozkładany