How To before the lvl required for a spell

Questions about addon itself.
7 posts Page 1 of 1
kado
Posts: 4
Joined: 24 Dec 2018, 23:15


Hi,

The warlock affliction need the spell haunt 48181 for the original rotation.
This spell came with the level 90.

Before this level, MaxDps abort with spell not found on action bar.

How can I use MaxDps before level 90 ? Should I use a custom rotation without the spell 48181 ?
Kaminaris
Site Admin
Posts: 410
Joined: 25 Jun 2017, 03:45


Yes you need custom rotation if you want to have support for low lever chars.
kado
Posts: 4
Joined: 24 Dec 2018, 23:15


Thx for the reply.

I do't really like the custom rotation, so I've modifie your code like this :

\MaxDps_Warlock\main.lua :

(perhaps should be in \MaxDps\Core.lua ?)
Code: Select all
--- sylvain
local playerLevel = UnitLevel("player");
and :
Code: Select all
	-- Sylvain Haunt est disponible seulement au level 90
	if playerLevel >= 90 then
	-- haunt,if=spell_targets.seed_of_corruption_aoe<=2+raid_event.invulnerable.up;
		if cooldown[AF.Haunt].ready and currentSpell ~= AF.Haunt and (targets <= 2) then
			return AF.Haunt;
		end
	end
Code: Select all
	-- Sylvain Haunt est disponible seulement au level 90
	if playerLevel >= 90 then
		-- haunt;
		if cooldown[AF.Haunt].ready and currentSpell ~= AF.Haunt then
			return AF.Haunt;
		end
	end
kado
Posts: 4
Joined: 24 Dec 2018, 23:15


I could make a branch on github if you want.
I've pull a merge request.
Kaminaris
Site Admin
Posts: 410
Joined: 25 Jun 2017, 03:45


You can make a fork of original repository but this will not be included in original addon. Meaning it will not be merged by me and pushed to curse.

But you are free to share it here or on discord.

People are really forgetting how extremely time consuming is maintaining all the classes, testing them, fixing them.
So when the new patch comes out and blizzard decides to change like half of the classes I will be doing this process over and over again.

It also goes against the original idea of keeping it simple.
Although it wouldn't be much overhead but ask yourself a question:
Do people need rotation helper for leveling?

The answer is no. It won't be long before they reach max level.
They wont be fighting enemies that will live longer than 30s even if they slap random buttons.

The small gain won't justify enormous amount of work.
kado
Posts: 4
Joined: 24 Dec 2018, 23:15


I understand your point of view. I consider it's during the leveling stage that we need the rotation helper ; to learn it ;)

Well, that's not a big deal, and thank you for your answer.
Kaminaris
Site Admin
Posts: 410
Joined: 25 Jun 2017, 03:45


You can only grasp a little about your rotation while leveling.
1. You dont have all spells/passives
2. Can't select last talent - which often changes rotations by a lot
3. You don't have azerite gear with often changes rotation.

And lastly, rotation is simply different when fighting raid or dungeon bosses at max level vs lower level.
7 posts Page 1 of 1
drogie łóżka stolik kawowy stół dębowy rozkładany