Working main.lua Retribution

12 posts Page 1 of 2
FireCulex
Posts: 5
Joined: 02 Aug 2018, 04:20


https://github.com/FireCulex/MaxDPS_Mod ... n/main.lua
I just added it there instead, code needs to be cleaned up, but it works, and a little holy section too.

based on the noxxic rotation guide
Kaminaris
Site Admin
Posts: 196
Joined: 25 Jun 2017, 03:45


It is better to use icy veins as rotation base. But I will take a look and probably upload it next.

Check my next stream today at 20:00 CEST i will be streaming addon development.
https://www.twitch.tv/kaminaris
FireCulex
Posts: 5
Joined: 02 Aug 2018, 04:20


Nice. Ended up making for the 3 talent trees for paladin, 4 for druid 3 for priest. Gonna do the 3 mage ones as well.

Sometimes its a bit tricky because the spells can have different id's in different tree's with the same name, and sometimes the spell id is different from the TargetAura id.
Rabindranat
Posts: 2
Joined: 03 Aug 2018, 20:45


Sorry but this class module not working for me...MaxDps Framework v8.0.2-beta
Jul 24, 2018, MaxDps Paladin Addon v8.0.1-beta, Game Client 8.0.1.27219 and the druid addon works well :shock:
Attachments
outdated.jpg
outdated.jpg (112.06 KiB) Viewed 213 times
Kaminaris
Site Admin
Posts: 196
Joined: 25 Jun 2017, 03:45


try removing it first and removing all settings
FireCulex
Posts: 5
Joined: 02 Aug 2018, 04:20


https://i.imgur.com/O0L2VFb.jpg
Code: Select all
if MaxDps:SpellAvailable(_HammerofWrath, timeShift) and holyPower <=4 and MaxDps:TargetPercentHealth() < 0.2 then
there is no target yet the circle remains?

update: I guess i worked around it by also adding MaxDps:TargetPercentHealth() > 0
Last edited by FireCulex on 04 Aug 2018, 07:30, edited 2 times in total.
Rabindranat
Posts: 2
Joined: 03 Aug 2018, 20:45


I've tried. Mod doesn't work for PaladinProtection. There is nothing for this spec in main.lua
function Paladin:Protection(timeShift, currentSpell, gcd, talents)

end
Kaminaris
Site Admin
Posts: 196
Joined: 25 Jun 2017, 03:45


Protection pal is not done yet. Tanks have lower prio than dpses
FireCulex
Posts: 5
Joined: 02 Aug 2018, 04:20


Image

How do you check for this? Notice there's no ID associated with it.
In holy spec there's no Aura like there is in Prot, and TargetAura doesn't work with targets that are immune, such as bosses. Can you force a 12 sec cd?
Code: Select all
if MaxDps:SpellAvailable(_HolyConsecration, timeShift) and not MaxDps:TargetAura(_HolyConsecrationAura, timeShift) then
is the existing line.
Kaminaris
Site Admin
Posts: 196
Joined: 25 Jun 2017, 03:45


There is ID always, just your UI doesn't show it. Well, working on default ui will be pain in the butt for you.
12 posts Page 1 of 2
drogie łóżka stolik kawowy stół dębowy rozkładany